From: Wolfgang Denk Date: Sun, 01 Feb 2009 16:12:58 +0100 Subject: [U-Boot] [PATCH 1/2] common/console: coding style cleanup In-Reply-To: <20090201130727.GF9067@game.jcrosoft.org> References: <1233486771-10411-1-git-send-email-plagnioj@jcrosoft.com> <20090201113212.6A79383644C3@gemini.denx.de> <20090201130727.GF9067@game.jcrosoft.org> Message-ID: <20090201151258.417E98322908@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jean-Christophe PLAGNIOL-VILLARD, In message <20090201130727.GF9067@game.jcrosoft.org> you wrote: > > > > -static int iomux_getc(void) > > > +static int iomux_getc (void) > > ... > > > -static int iomux_tstc(int file) > > > +static int iomux_tstc (int file) > > > > NAK. > > > > This Linux kernel coding style does NOT insert spaces between > > function names; your patch makes the style worse, not better. > It's the coding style use in this file We have a mix of styles here, so if we change it, then please to the "right" way. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Given a choice between two theories, take the one which is funnier.