Return-path: Received: from smtp4-g21.free.fr ([212.27.42.4]:49855 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751358AbZBCJom (ORCPT ); Tue, 3 Feb 2009 04:44:42 -0500 Date: Tue, 3 Feb 2009 10:39:25 +0100 From: Jean-Francois Moine To: kilgota@banach.math.auburn.edu, Adam Baker Cc: , Alan Stern Subject: Re: [PATCH] Add support for sq905 based cameras to gspca Message-ID: <20090203103925.25703074@free.fr> In-Reply-To: References: <200901192322.33362.linux@baker-net.org.uk> <200901272101.27451.linux@baker-net.org.uk> <200901272228.42610.linux@baker-net.org.uk> <20090128113540.25536301@free.fr> <20090131203650.36369153@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On Mon, 2 Feb 2009 20:36:31 -0600 (CST) kilgota@banach.math.auburn.edu wrote: > Just now when I logged in, a fortune came up which says: > > "A little experience often upsets a lot of theory." > > It struck me funny after our recent experiences, so I thought I would > share it with both of you. Hello, May be this message made me to look again at the gspca code. Well, it's my fault: I did not check the previous patch. Sorry for all trouble. The patch is simply: diff -r 3f4a7bc53d8e linux/drivers/media/video/gspca/gspca.c --- a/linux/drivers/media/video/gspca/gspca.c Mon Feb 02 20:25:38 2009 +0100 +++ b/linux/drivers/media/video/gspca/gspca.c Tue Feb 03 10:37:51 2009 +0100 @@ -435,7 +435,7 @@ break; gspca_dev->urb[i] = NULL; - if (!gspca_dev->present) + if (gspca_dev->present) usb_kill_urb(urb); if (urb->transfer_buffer != NULL) usb_buffer_free(gspca_dev->dev, Best regards. -- Ken ar c'hentan | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/