From: Ingo Molnar Subject: Re: [PATCH] xen: fix 32-bit build resulting from mmu move Date: Tue, 3 Feb 2009 18:36:12 +0100 Message-ID: <20090203173612.GA3528@elte.hu> References: <49876C6E.3010809@goop.org> <20090203122112.GD19979@elte.hu> <49887B79.4040708@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <49887B79.4040708@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: Linux Kernel Mailing List , the arch/x86 maintainers , Xen-devel , "H. Peter Anvin" List-Id: xen-devel@lists.xenproject.org * Jeremy Fitzhardinge wrote: > Ingo Molnar wrote: >> * Jeremy Fitzhardinge wrote: >> >> >>> Moving the mmu code from enlighten.c to mmu.c inadvertently broke the >>> 32-bit build. Fix it. >>> >>> Signed-off-by: Jeremy Fitzhardinge >>> --- >>> arch/x86/xen/mmu.c | 37 +++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 37 insertions(+) >>> >> >> that goes on top of the recent tip/x86/paravirt changes, right? No >> objections, i'm wondering why my testing didnt find any build breakage. >> Could you send me a .config that triggers the breakage? > > Any x86-32 + Xen build would hit it. +highmem+highpte would break a bit > more. i have a lot of successful builds with that pattern, that's why i asked for a specific config from you that definitely triggers it - i'd like to investigate how it escaped my testing procedures. Ingo