From: Ingo Molnar Subject: Re: [PATCH] xen: fix 32-bit build resulting from mmu move Date: Tue, 3 Feb 2009 19:14:25 +0100 Message-ID: <20090203181425.GA4884@elte.hu> References: <49876C6E.3010809@goop.org> <20090203122112.GD19979@elte.hu> <49887B79.4040708@goop.org> <20090203173612.GA3528@elte.hu> <49888787.30803@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <49888787.30803@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: Linux Kernel Mailing List , the arch/x86 maintainers , Xen-devel , "H. Peter Anvin" List-Id: xen-devel@lists.xenproject.org * Jeremy Fitzhardinge wrote: > Ingo Molnar wrote: >> i have a lot of successful builds with that pattern, that's why i asked >> for a specific config from you that definitely triggers it - i'd like >> to investigate how it escaped my testing procedures. >> > > Hm, I don't see how you could be; the functions are just outright > missing. Without the patch, the attached config fails with: > > $ make 'ARCH=i386' arch/x86/xen/mmu.o > [...] > CC arch/x86/xen/mmu.o > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1810: error: 'xen_kmap_atomic_pte' undeclared here (not in a function) > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1816: error: 'xen_set_pte_init' undeclared here (not in a function) > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1824: error: initializer element is not constant > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1824: error: (near initialization for 'xen_mmu_ops.pte_val') > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1825: error: initializer element is not constant > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1825: error: (near initialization for 'xen_mmu_ops.pgd_val') > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1827: error: initializer element is not constant > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1827: error: (near initialization for 'xen_mmu_ops.make_pte') > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1828: error: initializer element is not constant > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1828: error: (near initialization for 'xen_mmu_ops.make_pgd') > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1838: error: initializer element is not constant > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1838: error: (near initialization for 'xen_mmu_ops.make_pmd') > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1839: error: initializer element is not constant > /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1839: error: (near initialization for 'xen_mmu_ops.pmd_val') > make[3]: *** [arch/x86/xen/mmu.o] Error 1 > make[2]: *** [arch/x86/xen/mmu.o] Error 2 > make[1]: *** [sub-make] Error 2 > make: *** [all] Error 2 > hm, it triggers here too. Maybe the count of 32-bit tests wasnt high enough yet to hit this. Ingo