From: Mark Brown Subject: Re: [PATCH 2.6.30] ASoC: add additional controls to the CS4270 codec driver Date: Wed, 4 Feb 2009 14:08:33 +0000 Message-ID: <20090204140832.GA27713@rakim.wolfsonmicro.main> References: <1233680972-1443-1-git-send-email-timur@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id D82401038BF for ; Wed, 4 Feb 2009 15:08:34 +0100 (CET) Content-Disposition: inline In-Reply-To: <1233680972-1443-1-git-send-email-timur@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Timur Tabi Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, Feb 03, 2009 at 11:09:32AM -0600, Timur Tabi wrote: > Remove CONFIG_SND_SOC_CS4270_HWMUTE and always allow ASoC to control the mute > bits. The driver previously and erroneously assumed that these bits > control only external muting circuitry, but they also control internal > muting circuitry, so they should always be used. As discussed I'm holding off on this until the I2C folks decide what to do about the signal handling issue you found on teardown.