From: Wolfgang Denk Date: Wed, 04 Feb 2009 22:39:04 +0100 Subject: [U-Boot] [PATCH 4/9] A driver for the S6E63D6 SPI display controller from Samsung In-Reply-To: <59b21cf20902041054n747c67d4r1c99724978321586@mail.gmail.com> References: <59b21cf20902041054n747c67d4r1c99724978321586@mail.gmail.com> Message-ID: <20090204213904.CE0328322908@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <59b21cf20902041054n747c67d4r1c99724978321586@mail.gmail.com> Magnus Lilja wrote: ... > > +extern int s6e63d6_init(struct s6e63d6 *); > > +extern int s6e63d6_index(struct s6e63d6 *, u8); > > +extern int s6e63d6_param(struct s6e63d6 *, u16); > > 'extern' not needed. > > Also, personally I prefer to have the parameter names in the > prototypes as well, not just the data types. Strongly supported! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de My play was a complete success. The audience was a failure.