From: Wolfgang Denk Date: Wed, 04 Feb 2009 23:00:57 +0100 Subject: [U-Boot] [PATCH 1/9] i.MX31: fix SPI driver for shorter than 32 bit transfers In-Reply-To: <20090204214259.GA7238@ld0162-tx32.am.freescale.net> References: <20090204213032.A9BE78322908@gemini.denx.de> <20090204214259.GA7238@ld0162-tx32.am.freescale.net> Message-ID: <20090204220057.2C7A68322908@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Scott Wood, In message <20090204214259.GA7238@ld0162-tx32.am.freescale.net> you wrote: > > > > + i++, in_l++, out_l++) > > > + *in_l = spi_xchg_single(slave, *out_l, flags); > > > > Please use TABs for indentation, and add curly braces because of the > > multi-line for construct. > > I think you mistook the continuation line for the for-body? Why would > you want to TAB the continuation line, making it even less distinct from > the body of the for-statement? Your're right. Guennadi, please ignore this part. > Besides, the above patch doesn't change formatting in any way. That doesn't mean it should not be fixed if it was wrong :-) > That said, it could certainly use most of the loop content being moved > into the body. Indeed - that woul dbe much easier to read. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de What kind of love is that? Not to be loved; never to have shown love. -- Commissioner Nancy Hedford, "Metamorphosis", stardate 3219.8