From: Mark Brown Subject: Re: [PATCH 3/3] ASoC: Blackfin: fix bug - kernel will crash when record and play in bf527-ezkit Date: Fri, 6 Feb 2009 11:56:45 +0000 Message-ID: <20090206115626.GD8723@sirena.org.uk> References: <1233915156-17985-1-git-send-email-cooloney@kernel.org> <1233915156-17985-4-git-send-email-cooloney@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id CA9CA2432C for ; Fri, 6 Feb 2009 12:56:56 +0100 (CET) Content-Disposition: inline In-Reply-To: <1233915156-17985-4-git-send-email-cooloney@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Bryan Wu Cc: alsa-devel@alsa-project.org, Cliff Cai List-Id: alsa-devel@alsa-project.org On Fri, Feb 06, 2009 at 06:12:36PM +0800, Bryan Wu wrote: > From: Cliff Cai > > set constraint only if the value is not 0, change the configuring way for sport > Signed-off-by: Cliff Cai > Signed-off-by: Bryan Wu If this is fixing a kernel crash we should push it for 2.6.29 (the code hasn't changed so I'm assuming it occurs there). What is the crash that is being fixed? > --- > sound/soc/blackfin/bf5xx-i2s.c | 25 ++++--------------------- > sound/soc/codecs/ssm2602.c | 29 ++++++++++++++--------------- > 2 files changed, 18 insertions(+), 36 deletions(-) Presumably only one of these drivers needs to be changed for the crash fix? I'd have expected to see two separate patches for the two separate drivers - the changes don't depend on each other and do very different things.