From: Marcelo Tosatti Subject: Re: [PATCH 0/3][v2] Fix racy in kvm_free_assigned_irq Date: Fri, 6 Feb 2009 10:33:17 -0200 Message-ID: <20090206123317.GA6075@amt.cnet> References: <1231207383-22625-1-git-send-email-sheng@linux.intel.com> <49632297.5000008@redhat.com> <1233917358.27709.23.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Sheng Yang , kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:41178 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbZBHFoI (ORCPT ); Sun, 8 Feb 2009 00:44:08 -0500 Content-Disposition: inline In-Reply-To: <1233917358.27709.23.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Feb 06, 2009 at 10:49:18AM +0000, Mark McLoughlin wrote: > On Tue, 2009-01-06 at 11:21 +0200, Avi Kivity wrote: > > Sheng Yang wrote: > > > Hi Avi > > > > > > I just add a comment for kvm_free_assigned_irq(). The other things are all > > > the same as the patchset you have reviewed. > > > > > > > Applied, thanks. > > These would make sense for 2.6.29, right? Yep, these have been pushed to branch kvm-updates/2.6.29. > I just saw the oops below when I killed a busy guest with an assigned > device, and it looks like it might be related. Yep. kvm_put_kvm from kvm_assigned_dev_interrupt_work_handler is gone. > Cheers, > Mark. > > BUG: unable to handle kernel paging request at 0000000000200200 > IP: [] list_del+0x10/0x85 > PGD 171c82067 PUD 1741d8067 PMD 0