From: Wolfgang Denk Date: Mon, 09 Feb 2009 15:27:53 +0100 Subject: [U-Boot] [PATCH 2/3][v3] dnet: driver for Dave DNET ethernet controller In-Reply-To: <49902403.2010406@emcraft.com> References: <1234043985-9820-1-git-send-email-yanok@emcraft.com> <1234043985-9820-3-git-send-email-yanok@emcraft.com> <498FD452.2010501@gmail.com> <49902403.2010406@emcraft.com> Message-ID: <20090209142753.B1F218322908@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Ilya, In message <49902403.2010406@emcraft.com> you wrote: > ... > >> + u32 TX_JUMBO_CNT; > >> + u32 TX_BYTE_CNT; > >> +} __attribute__((packed)); > >> > > Why is this packed? All fields are 32-bit aligned already. > > Generally, I prefer declaring such structures with ((packed)) regardless > of if it's really do something. Just to show that it should be packed. Can you please verify that it works as well without the "packed", and if it does (as expected) resubmit without it? Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Drawing on my fine command of language, I said nothing.