From: Wolfgang Denk Date: Tue, 10 Feb 2009 00:32:01 +0100 Subject: [U-Boot] [PATCH 2/2] mpc8641hpcn: Use physical address in flash banks defintion In-Reply-To: <1233614092-5480-2-git-send-email-beckyb@kernel.crashing.org> References: <1233614092-5480-1-git-send-email-beckyb@kernel.crashing.org> <1233614092-5480-2-git-send-email-beckyb@kernel.crashing.org> Message-ID: <20090209233201.358B8832E893@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Becky Bruce, In message <1233614092-5480-2-git-send-email-beckyb@kernel.crashing.org> you wrote: > If the VA and PA of the flash aren't the same, the banks list > should be initialized to hold the physical address. Correct this. > > Signed-off-by: Becky Bruce > --- > include/configs/MPC8641HPCN.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/configs/MPC8641HPCN.h b/include/configs/MPC8641HPCN.h > index 5a83296..ceb8e54 100644 > --- a/include/configs/MPC8641HPCN.h > +++ b/include/configs/MPC8641HPCN.h > @@ -186,7 +186,7 @@ extern unsigned long get_board_sys_clk(unsigned long dummy); > #define CONFIG_SYS_FLASH_BASE_PHYS (CONFIG_SYS_FLASH_BASE \ > | CONFIG_SYS_PHYS_ADDR_HIGH) > > -#define CONFIG_SYS_FLASH_BANKS_LIST {CONFIG_SYS_FLASH_BASE} > +#define CONFIG_SYS_FLASH_BANKS_LIST {CONFIG_SYS_FLASH_BASE_PHYS} > > #define CONFIG_SYS_BR0_PRELIM (BR_PHYS_ADDR(CONFIG_SYS_FLASH_BASE_PHYS) \ > | 0x00001001) /* port size 16bit */ Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A secure program has to be robust: it must be able to deal with conditions that "can't happen", whether user input, program error or library/etc. This is basic damage control. Buffer overflow errors have nothing to do with security, but everything with stupidity. -- Wietse Venema in <5cnqm3$8r9@spike.porcupine.org>