Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LXGVV-0005tp-RU for qemu-devel@nongnu.org; Wed, 11 Feb 2009 09:56:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LXGVO-0005nQ-56 for qemu-devel@nongnu.org; Wed, 11 Feb 2009 09:56:07 -0500 Received: from [199.232.76.173] (port=42593 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LXGVO-0005nC-0D for qemu-devel@nongnu.org; Wed, 11 Feb 2009 09:56:02 -0500 Received: from mx2.redhat.com ([66.187.237.31]:54634) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LXGVN-0007Rg-4g for qemu-devel@nongnu.org; Wed, 11 Feb 2009 09:56:01 -0500 Date: Wed, 11 Feb 2009 12:59:15 -0200 From: Glauber Costa Message-ID: <20090211145915.GB27729@poweredge.glommer> References: <1234360034-19459-1-git-send-email-glommer@redhat.com> <4992DF4B.6070109@siemens.com> <20090211143732.GA27729@poweredge.glommer> <4992E499.8050502@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4992E499.8050502@siemens.com> Subject: [Qemu-devel] Re: [PATCH] remove smaller slots if registering a bigger one Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org > > > > Now, if you remember the last memory patches I sent, it actually removes > > this line. However, this is because in that alternative, we were tracking > > mmio regions in qemu, but not in kvm. so flags >= TLB_MMIO would just > > delete it from the kernel mapping, but qemu would not forget about it. > > > > This is to show that I believe that it might be possible to handle mmio > > regions slightly different, but I don't think just dropping this line would > > help much. > > What confused me most here - and still does - is that TLB_* flags make > semantically no sense to me in the physical memory > registering/unregistering context. They should only show up in > CPUTLBEntry, no? But maybe I'm overseeing some strange relation. > I might be wrong, but I believe it's used quite often in normal memory to track pieces of memory in which we do mmio.