From: Mike Frysinger Date: Wed, 11 Feb 2009 18:40:34 -0500 Subject: [U-Boot] [PATCH 17/40] Blackfin: overhaul i2c driver In-Reply-To: References: <1232733641-29276-1-git-send-email-vapier@gentoo.org> <1232733641-29276-18-git-send-email-vapier@gentoo.org> Message-ID: <200902111840.35396.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 11 February 2009 18:19:36 Timur Tabi wrote: > On Fri, Jan 23, 2009 at 12:00 PM, Mike Frysinger wrote: > > The current Blackfin i2c driver does not work properly with certain > > devices due to it breaking up transfers incorrectly. This is a rewrite > > of the driver and relocates it to the newer place in the source tree. > > > > Also remove duplicated I2C speed defines in Blackfin board configs and > > disable I2C slave address usage since it isn't implemented. > > > > Signed-off-by: Mike Frysinger > > include/i2c.h still has this: > > static inline void i2c_reg_write(u8 addr, u8 reg, u8 val) > { > ... > #ifdef CONFIG_BLACKFIN > /* This ifdef will become unneccessary in a future version of the > * blackfin I2C driver. > */ > i2c_write(addr, reg, 0, &val, 1); > #else > i2c_write(addr, reg, 1, &val, 1); > #endif > } > > There's a similar #ifdef in i2c_reg_read(). Are these #ifdefs still > necessary? If so, could you modify your I2C driver so that they > aren't? And then fix i2c.h as well? ugh, i told the guy submitting those changes to ignore the Blackfin i2c driver. the ifdef's in the common code should be dropped, thanks for pointing this out. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090211/f825bae6/attachment.pgp