From: Ingo Molnar Subject: Re: [patch] rt: res_counter fix, v2 Date: Thu, 12 Feb 2009 15:46:24 +0100 Message-ID: <20090212144624.GB14616@elte.hu> References: <20090212005032.GA4788@nowhere> <20090212021257.GB4697@nowhere> <20090212101650.GA1096@elte.hu> <20090212102113.GA10031@elte.hu> <20090212142806.GA5865@nowhere> <1234449701.10603.10.camel@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Frederic Weisbecker , Thomas Gleixner , LKML , rt-users , Steven Rostedt , Carsten Emde , Clark Williams To: Peter Zijlstra Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:49920 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbZBLOqn (ORCPT ); Thu, 12 Feb 2009 09:46:43 -0500 Content-Disposition: inline In-Reply-To: <1234449701.10603.10.camel@laptop> Sender: linux-rt-users-owner@vger.kernel.org List-ID: * Peter Zijlstra wrote: > On Thu, 2009-02-12 at 15:28 +0100, Frederic Weisbecker wrote: > > > [ 45.228589] hardirqs last disabled at (0): [] copy_process+0x68d/0x1500 > > > [ 45.228602] softirqs last enabled at (0): [] copy_process+0x68d/0x1500 > > > > > > The reason for which I wanted to send an irqsoff trace is that the above lines are false. > > copy_process() has: > > #endif > p->hardirq_enable_ip = 0; > p->hardirq_enable_event = 0; > p->hardirq_disable_ip = _THIS_IP_; > p->hardirq_disable_event = 0; > p->softirqs_enabled = 1; > p->softirq_enable_ip = _THIS_IP_; > p->softirq_enable_event = 0; > p->softirq_disable_ip = 0; > p->softirq_disable_event = 0; > p->hardirq_context = 0; > p->softirq_context = 0; > #endif > > the sequence count of 0 basically tells you it hasn't been set yet. maybe we should initialize it to -1 to make this more apparent? Ingo