From: Mike Frysinger Date: Mon, 16 Feb 2009 14:59:43 -0500 Subject: [U-Boot] [PATCH 27/27] remove bi_enet*addr from global data for all arches In-Reply-To: <20090216194752.F145A832E893@gemini.denx.de> References: <1234596190-524-1-git-send-email-vapier@gentoo.org> <200902161429.10360.vapier@gentoo.org> <20090216194752.F145A832E893@gemini.denx.de> Message-ID: <200902161459.45065.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 16 February 2009 14:47:52 Wolfgang Denk wrote: > In message <200902161429.10360.vapier@gentoo.org> you wrote: > > > > at any rate, is there a define that can be keyed off of ? > > > > CONFIG_HAS_FDT or some such junk ? then the behavior can be changed > > > > to like: #ifndef CONFIG_HAS_FDT > > > > /* ABI compat junk */ > > > > uchar bi_padding_was_enetaddr[6]; > > > > #endif > > > > > > Why not just leave the bd_t alone, until such a time as we can get rid > > > of it altogether? > > > > > > Note that just because we support booting with device trees doesn't > > > mean we don't also support booting legacy kernels. > > > > the name has to go. u-boot no longer uses that field and leaving it in > > will simply lead to code misusing it creeping it back into the tree. > > whether you choose to force the warts on everyone is up to you ... i'm > > not a ppc consumer so i could care less. > > You are not permitted to change this interface. It must remain > stable. There are systems out there running really old kernel > versions, and every now and then they may even need to update U-Boot > to adapt it for recent hardware changes, while they cannot change the > kernel. It is mandatory that even old 2.4 kernel versions must be > bootable with recent versions of U-Boot. > > As mentioned before, bd_info is a binary interfwace between U-Boot and > the Linux kernel, and it must not be changed. i'm not talking about changing the binary aspect of it. i'm talking about changing the API. two completely different things. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090216/4e7e55cb/attachment.pgp