From: Mike Frysinger Date: Mon, 16 Feb 2009 19:03:27 -0500 Subject: [U-Boot] [PATCH 21/27] cmc_pu2: get mac address from environment In-Reply-To: <20090216225617.C1B0B832E893@gemini.denx.de> References: <1234596190-524-1-git-send-email-vapier@gentoo.org> <1234596190-524-22-git-send-email-vapier@gentoo.org> <20090216225617.C1B0B832E893@gemini.denx.de> Message-ID: <200902161903.28898.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 16 February 2009 17:56:17 Wolfgang Denk wrote: > In message Mike Frysinger wrote: > > The environment is the canonical storage location of the mac address, so > > we're killing off the global data location and moving everything to > > querying the env directly. > > > > Also rename load_sernum_ethaddr() to misc_init_r() so we don't need to > > handle this board specially in common ARM code. > > ... > > > -#ifdef CONFIG_CMC_PU2 > > - load_sernum_ethaddr (); > > -#endif /* CONFIG_CMC_PU2 */ > > - > > If we bisect here, we have broken boards because load_sernum_ethaddr() > is no longer called but the new init code is not installed yet. umm, are you sure ? the arm port is nicer than the ppc port because there is only one board that uses load_sernum_ethaddr(). so in 1 change, i dropped the call to load_sernum_ethaddr() and had the board move to misc_init_r(). i see no breakage in this change. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090216/174fa655/attachment.pgp