From: Mike Frysinger Date: Mon, 16 Feb 2009 19:05:11 -0500 Subject: [U-Boot] [PATCH 22/27] pcs440ep: get mac address from environment and move load_sernum_ethaddr() to board init In-Reply-To: <20090216225722.456F3832E893@gemini.denx.de> References: <1234596190-524-1-git-send-email-vapier@gentoo.org> <1234596190-524-23-git-send-email-vapier@gentoo.org> <20090216225722.456F3832E893@gemini.denx.de> Message-ID: <200902161905.12952.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 16 February 2009 17:57:22 Wolfgang Denk wrote: > In message Mike Frysinger wrote: > > The environment is the canonical storage location of the mac address, so > > we're killing off the global data location and moving everything to > > querying the env directly. > > > > Move all the work of load_sernum_ethaddr() into a local load_ethaddr() > > func and call that from misc_init_r(). We leave load_sernum_ethaddr() > > as a stub so that it can be removed from all places in a later commit. > > > > Signed-off-by: Mike Frysinger > > CC: Stefan Roese > > CC: Ben Warren > > ... > > > +void load_sernum_ethaddr (void) > > +{ > > +} > > + > > See previous comments - please do not add dead code just to remove it > later. your previous comment doesnt apply to these later ones. the first change is for arm-only. the later changes are for ppc. it isnt dead code because the function is still called by common ppc code. just like i outlined in the summary for this patchset. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090216/5321d2a4/attachment.pgp