From: Wolfgang Denk Date: Mon, 16 Feb 2009 21:14:32 +0100 Subject: [U-Boot] [PATCH 27/27] remove bi_enet*addr from global data for all arches In-Reply-To: <200902161459.45065.vapier@gentoo.org> References: <1234596190-524-1-git-send-email-vapier@gentoo.org> <200902161429.10360.vapier@gentoo.org> <20090216194752.F145A832E893@gemini.denx.de> <200902161459.45065.vapier@gentoo.org> Message-ID: <20090216201432.C1646832E893@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, In message <200902161459.45065.vapier@gentoo.org> you wrote: > > > As mentioned before, bd_info is a binary interfwace between U-Boot and > > the Linux kernel, and it must not be changed. > > i'm not talking about changing the binary aspect of it. i'm talking about > changing the API. two completely different things. Then I don't understand what you are talking about or what your patch is doing. To me it looks as if you were removing the bi_enetaddr[] resp. bi_enet?addr[] from the bd_info structure. Such a modification is not permitted, the bd_info structure must be kept constant and unchanged *and* the respective fields must be correctly initialized before booting the Linux kernel. This is mandatory. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Even if you aren't in doubt, consider the mental welfare of the per- son who has to maintain the code after you, and who will probably put parens in the wrong place. - Larry Wall in the perl man page