From: Wolfgang Denk Date: Mon, 16 Feb 2009 22:46:16 +0100 Subject: [U-Boot] [PATCH] 2/12 Multiadapter/multibus I2C, common part 2 In-Reply-To: References: Message-ID: <20090216214616.694FA832E893@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear ksi at koi8.net, In message you wrote: > Signed-off-by: Sergey Kubushyn > --- > diff -purN u-boot-i2c.orig/cpu/mpc8xx/video.c u-boot-i2c/cpu/mpc8xx/video.c > --- u-boot-i2c.orig/cpu/mpc8xx/video.c 2009-02-12 10:43:41.000000000 -0800 > +++ u-boot-i2c/cpu/mpc8xx/video.c 2009-02-12 10:46:00.000000000 -0800 Looking close at this "common part 2" patch I think your patches are not split orthogonally - to me it seems as if "common part 1" and "common part 2" cannot be separated without causing bisect problems. Please fix - and check the rmaining patches for other, similar issues. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Niklaus Wirth has lamented that, whereas Europeans pronounce his name correctly (Ni-klows Virt), Americans invariably mangle it into (Nick- les Worth). Which is to say that Europeans call him by name, but Americans call him by value.