From: Wolfgang Denk Date: Mon, 16 Feb 2009 22:48:44 +0100 Subject: [U-Boot] [PATCH] 5/12 Multiadapter/multibus I2C, drivers part 2 In-Reply-To: References: Message-ID: <20090216214844.0C04E832E893@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear ksi at koi8.net, In message you wrote: > ... > -int i2c_read (uchar chip, uint addr, int alen, uchar * buffer, int len) > +static int omap1510_i2c_read (uchar chip, uint addr, int alen, uchar * buffer, int len) > { > int i; > > if (alen > 1) { > - printf ("I2C read: addr len %d not supported\n", alen); > + printf ("%s: addr len %d not supported\n", __FUNCTION__, alen); > return 1; > } > > if (addr + len > 256) { > - printf ("I2C read: address out of range\n"); > + printf ("%s: address out of range\n", __FUNCTION__); These are changes really to the worse: instead of I2C read: address out of range we now get omap1510_i2c_read: address out of range More difficult to read, higher memory footprint. Please revert this. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Today's robots are very primitive, capable of understanding only a few simple instructions such as 'go left', 'go right', and 'build car'." - John Sladek