From: Wolfgang Denk Date: Mon, 16 Feb 2009 22:58:14 +0100 Subject: [U-Boot] [PATCH] 7/12 Multiadapter/multibus I2C, drivers part 4 In-Reply-To: References: Message-ID: <20090216215814.58E35832E893@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear ksi at koi8.net, In message you wrote: > > +#define I2C_SOFT_SEND_START(n) \ > +static void send_start##n(void) \ > +{ \ > + I2C_SOFT_DECLARATIONS##n \ > + I2C_DELAY##n; \ > + I2C_SDA##n(1); \ > + I2C_ACTIVE##n; \ > + I2C_DELAY##n; \ > + I2C_SCL##n(1); \ > + I2C_DELAY##n; \ > + I2C_SDA##n(0); \ > + I2C_DELAY##n; \ > } Sorry, but that's becoming an unreadable mess. I don't think I'm going to ACK such code. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It is common sense to take a method and try it. If it fails, admit it frankly and try another. But above all, try something. - Franklin D. Roosevelt