From: Wolfgang Denk Date: Mon, 16 Feb 2009 23:00:38 +0100 Subject: [U-Boot] [PATCH] 8/12 Multiadapter/multibus I2C, configs part 1 In-Reply-To: References: Message-ID: <20090216220038.BC993832E893@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear ksi at koi8.net, In message you wrote: > > -#define CONFIG_HARD_I2C /* I2C with hardware support*/ > -#undef CONFIG_SOFT_I2C /* I2C bit-banged */ > -#define CONFIG_SYS_I2C_SPEED 400000 /* I2C speed and slave address */ > -#define CONFIG_SYS_I2C_EEPROM_ADDR 0x57 > -#define CONFIG_SYS_I2C_SLAVE 0x7F > -#define CONFIG_SYS_I2C_NOPROBES {0x69} /* Don't probe these addrs */ > -#define CONFIG_SYS_I2C_OFFSET 0x3000 > +#define CONFIG_NEW_I2C /* New I2C code */ > +#define CONFIG_FSL_I2C /* Use FSL common I2C driver */ > +#define CONFIG_SYS_FSL_I2C_SPEED 400000 /* I2C speed and slave address */ > +#define CONFIG_SYS_FSL_I2C_EEPROM_ADDR 0x57 > +#define CONFIG_SYS_FSL_I2C_SLAVE 0x7F > +#define CONFIG_SYS_I2C_NOPROBES {0x69} /* Don't probe these addrs */ > +#define CONFIG_SYS_FSL_I2C_OFFSET 0x3000 > +#define CONFIG_SYS_I2C_ADAPTERS {&fsl_i2c_adap[0]} Do we really need sucheven more unreadable names? Why do you have to add the FSL_, SOFT_, ... everywhere? I think this should be redundant. Omit it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "I used to think that the brain was the most wonderful organ in my body. Then I realized who was telling me this." - Emo Phillips