From: Wolfgang Denk Date: Mon, 16 Feb 2009 23:57:22 +0100 Subject: [U-Boot] [PATCH 22/27] pcs440ep: get mac address from environment and move load_sernum_ethaddr() to board init In-Reply-To: <1234596190-524-23-git-send-email-vapier@gentoo.org> References: <1234596190-524-1-git-send-email-vapier@gentoo.org> <1234596190-524-23-git-send-email-vapier@gentoo.org> Message-ID: <20090216225722.456F3832E893@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, In message <1234596190-524-23-git-send-email-vapier@gentoo.org> you wrote: > The environment is the canonical storage location of the mac address, so > we're killing off the global data location and moving everything to > querying the env directly. > > Move all the work of load_sernum_ethaddr() into a local load_ethaddr() > func and call that from misc_init_r(). We leave load_sernum_ethaddr() > as a stub so that it can be removed from all places in a later commit. > > Signed-off-by: Mike Frysinger > CC: Stefan Roese > CC: Ben Warren ... > +void load_sernum_ethaddr (void) > +{ > +} > + See previous comments - please do not add dead code just to remove it later. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I think it's a new feature. Don't tell anyone it was an accident. :-) -- Larry Wall on s/foo/bar/eieio in <10911@jpl-devvax.JPL.NASA.GOV>