From: Wolfgang Denk Date: Tue, 17 Feb 2009 01:31:11 +0100 Subject: [U-Boot] [PATCH 22/27] pcs440ep: get mac address from environment and move load_sernum_ethaddr() to board init In-Reply-To: <200902161922.44211.vapier@gentoo.org> References: <1234596190-524-1-git-send-email-vapier@gentoo.org> <200902161905.12952.vapier@gentoo.org> <20090217001613.F3D5B832E893@gemini.denx.de> <200902161922.44211.vapier@gentoo.org> Message-ID: <20090217003111.A1A28832E893@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, In message <200902161922.44211.vapier@gentoo.org> you wrote: > > > Well, there is a very small number of boards. Why cannot we have this > > change in one step, in one commit? Adding empty functions just to > > remove them later seems sub-optimal to me. > > in my mind, what i did is more logical. i'll do whatever way you want though. > so just explicitly state "squash those changes into one even though they touch > a bunch of different places" and i'll happily do it. Hm... maybe somebody else comments? Stefan, Ben? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Sometimes a feeling is all we humans have to go on. -- Kirk, "A Taste of Armageddon", stardate 3193.9