From: Simon Horman Subject: [rfc 17/18] ioemu: sort pass-through PCI devices before inserting Date: Tue, 17 Feb 2009 20:08:05 +1100 Message-ID: <20090217091548.038589579@vergenet.net> References: <20090217090748.580007796@vergenet.net> Return-path: Content-Disposition: inline; filename=regex-qsort.patch List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org When passing though a milti-function device it is important that function zero is inserted first as the multifunction bit in its PCI_HEADER_TYPE needs to be chacked to verify that the device is multi-function and enable probing of non-zero functions in (Linux and probably other) guests. Signed-off-by: Simon Horman Index: ioemu-remote/hw/pass-through.c =================================================================== --- ioemu-remote.orig/hw/pass-through.c 2009-02-17 17:51:30.000000000 +0900 +++ ioemu-remote/hw/pass-through.c 2009-02-17 17:52:08.000000000 +0900 @@ -751,6 +751,11 @@ static int cmp_php_dev(const struct php_ return 0; } +static int cmp_php_dev_for_qsort(const void *a, const void *b) +{ + return cmp_php_dev(a, b); +} + static void cpy_php_dev(struct php_dev *dst, const struct php_dev *src) { memcpy(dst, src, sizeof(*dst)); @@ -937,6 +942,7 @@ static struct php_dev *parse_bdf(const c } regfree(&preg); + qsort(list, nmemb, sizeof(*list), cmp_php_dev_for_qsort); return list; err: -- -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en