Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n1H9dSFY215927 for ; Tue, 17 Feb 2009 03:39:29 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 6BF6115A02BA for ; Tue, 17 Feb 2009 01:38:55 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id vZk1z8NYT9Cx0UvB for ; Tue, 17 Feb 2009 01:38:55 -0800 (PST) Date: Tue, 17 Feb 2009 04:38:24 -0500 From: Christoph Hellwig Subject: Re: [PATCH] xfsdump: fix system() error reporting Message-ID: <20090217093824.GB15620@infradead.org> References: <20090216102845.GA6835@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Timothy Shimmin Cc: Christoph Hellwig , xfs@oss.sgi.com On Tue, Feb 17, 2009 at 11:08:33AM +1100, Timothy Shimmin wrote: > Hi Christoph, > > Looks reasonable. > Though, in the case of returning -1, it might be more interesting > to know the value of errno ? (I presume errno would be set in that case). >From looking at the manpage and the glibc implementation it seem like system does not actually set errno. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs