From: Mike Frysinger Date: Tue, 17 Feb 2009 16:53:26 -0500 Subject: [U-Boot] [PATCH 03/30] net: new utility functions for working with enetaddr's In-Reply-To: <1234847451-3210-4-git-send-email-vapier@gentoo.org> References: <1234847451-3210-1-git-send-email-vapier@gentoo.org> <1234847451-3210-4-git-send-email-vapier@gentoo.org> Message-ID: <200902171653.27038.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 17 February 2009 00:10:24 Mike Frysinger wrote: > +int eth_getenv_enetaddr(char *name, uchar *enetaddr) > +{ > + int ret = 0; > + char *addr; > + > + addr = getenv(name); > + if (!addr) > + ret = -1; > + eth_parse_enetaddr(addr, enetaddr); > + > + return ret; > +} the return value isnt shaping up the way i expected in most every other place. i'll change it to read: return is_valid_ether_addr(enetaddr); that way it'll behave as expected: 0->failure, 1->success -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090217/1ef60025/attachment.pgp