From: Wolfgang Denk Date: Wed, 18 Feb 2009 00:30:51 +0100 Subject: [U-Boot] [PATCH] tsec: report when there is no vendor specific PHY support. In-Reply-To: <29f2f2fe7e8a340b4bad9db14d2f6d3844cf8964.1228951215.git.paul.gortmaker@windriver.com> References: <29f2f2fe7e8a340b4bad9db14d2f6d3844cf8964.1228951215.git.paul.gortmaker@windriver.com> Message-ID: <20090217233051.55EDC832E893@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Ben, In message <29f2f2fe7e8a340b4bad9db14d2f6d3844cf8964.1228951215.git.paul.gortmaker@windriver.com> Paul Gortmaker wrote: > Commit af1c2b84 added a generic phy support, with an ID of zero > and a 32 bit mask; meaning that it will match on any PHY ID. > > The problem is that there is a test that checked if a matching > PHY was found, and if not, it printed the non-matching ID. > But since there will always be a match (on the generic PHY, > worst case), this test will never trip. > > In the case of a misconfigured PHY address, or of a PHY that > isn't explicitly supported outside of the generic support, > you will never see the ID of 0xffffffff, or the ID of the > real (but unsupported) chip. It will silently fall through > onto the generic support. > > This change makes that test useful again, and ensures that > the selection of generic PHY support doesn't happen without > some sort of notice. It also makes it explicitly clear that > the generic PHY must be last in the PHY table. > > Signed-off-by: Paul Gortmaker > --- > drivers/net/tsec.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) This patch was ACKed by Andy, but I don't think it was applied. Was this intentional or by accident? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Monday is an awful way to spend one seventh of your life.