From: Kim Phillips Date: Wed, 18 Feb 2009 15:20:03 -0600 Subject: [U-Boot] [PATCH v3] MPC8349ITX: several config issues fixed In-Reply-To: References: <12337648692469-git-send-email-gvv@lstec.com> <20090216192832.a70bb664.kim.phillips@freescale.com> Message-ID: <20090218152003.b418810d.kim.phillips@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 17 Feb 2009 15:54:52 -0600 Timur Tabi wrote: > On Tue, Feb 17, 2009 at 3:49 PM, Kumar Gala wrote: > > The default value is 256M so I don't thing the change is need anymore. > > Huh? I think his patch is supposed to address the fact that 256MB is > the limit, and he wants to add more. so this commit started producing warnings for boards that defined their own CONFIG_MAX_MEM_MAPPED, such as the SIMPC8313 (with 512MB): commit 87c9063963561d3d01064be34d0c30855a56587b Author: Kumar Gala Date: Thu Feb 5 20:40:58 2009 -0600 ppc: Move CONFIG_MAX_MEM_MAPPED to common config.h Moved CONFIG_MAX_MEM_MAPPED to the asm/config.h so its kept consistent between the two current users (lib_ppc/board.c, 44x SPD DDR2). Signed-off-by: Kumar Gala Acked-by: Stefan Roese the warnings are: In file included from /home/r1aaha/git/u-boot/include/config.h:5, from /home/r1aaha/git/u-boot/include/common.h:35, from simpc8313.c:26: /home/r1aaha/git/u-boot/include/configs/SIMPC8313.h:81:1: warning: "CONFIG_MAX_MEM_MAPPED" redefined In file included from /home/r1aaha/git/u-boot/include/config.h:4, from /home/r1aaha/git/u-boot/include/common.h:35, from simpc8313.c:26: /home/r1aaha/git/u-boot/include/asm/config.h:28:1: warning: this is the location of the previous definition which is probably all due to include/config.h including the file with the default value prior to the board's config: /* Automatically generated - do not edit */ #include #include So how are boards supposed to define their own CONFIG_MAX_MEM_MAPPED now? In the Makefile? Or is there a better place for this default value? Kim