From: Kim Phillips Date: Wed, 18 Feb 2009 17:09:57 -0600 Subject: [U-Boot] [PATCH] mkconfig: include board config.h before asm/config.h In-Reply-To: <20090218221552.95362832E43F@gemini.denx.de> References: <20090218161429.d2a02a7b.kim.phillips@freescale.com> <20090218221552.95362832E43F@gemini.denx.de> Message-ID: <20090218170957.5013c73d.kim.phillips@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 18 Feb 2009 23:15:52 +0100 Wolfgang Denk wrote: > Dear Kim Phillips, > > In message <20090218161429.d2a02a7b.kim.phillips@freescale.com> you wrote: > > swapping the include order suppresses warnings for board configs > > that define their own CONFIG_MAX_MEM_MAPPED: > ... > > echo "/* Automatically generated - do not edit */" >>config.h > > -echo "#include " >>config.h > > echo "#include " >>config.h > > +echo "#include " >>config.h > > That's a pretty big hammer that affects ALL boards. > > Are you absolutely sure it has no negative side effects? unfortunately I don't have a supercomputer over here, so I can't be 100% sure. I did however check samples from 4xx, 83xx, 85xx, and 86xx - due to recent relevant chatter wrt those platforms. The alternative is to search for a better home for CONFIG_MAX_MEM_MAPPED's default definition. Kim