From: Wolfgang Denk Date: Thu, 19 Feb 2009 00:36:25 +0100 Subject: [U-Boot] [PATCH] mkconfig: include board config.h before asm/config.h In-Reply-To: <20090218161429.d2a02a7b.kim.phillips@freescale.com> References: <20090218161429.d2a02a7b.kim.phillips@freescale.com> Message-ID: <20090218233625.CFB99832E43F@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Kim Phillips, In message <20090218161429.d2a02a7b.kim.phillips@freescale.com> you wrote: > swapping the include order suppresses warnings for board configs > that define their own CONFIG_MAX_MEM_MAPPED: > > In file included from /home/r1aaha/git/u-boot/include/config.h:5, > from /home/r1aaha/git/u-boot/include/common.h:35, > from simpc8313.c:26: > /home/r1aaha/git/u-boot/include/configs/SIMPC8313.h:81:1: warning: > "CONFIG_MAX_MEM_MAPPED" redefined > In file included from /home/r1aaha/git/u-boot/include/config.h:4, > from /home/r1aaha/git/u-boot/include/common.h:35, > from simpc8313.c:26: > /home/r1aaha/git/u-boot/include/asm/config.h:28:1: warning: this is > the location of the previous definition > > Signed-off-by: Kim Phillips > --- > mkconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I've been programming for (35-9=) 24 years myself, and I find the best way to learn a new language is to *read* every example snippet I can find, with a reference book close by. Eventually, the *rhythm* of the language starts pounding in my head... and my fluency is close at hand. That's how I learned Perl, and now I'm one of the drummers. :-) -- Randal L. Schwartz in <8cvi6p2tir.fsf@gadget.cscaper.com>