Return-path: Received: from smtp.sissa.it ([147.122.11.135]:50234 "EHLO smtp.sissa.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752097AbZBSQl6 (ORCPT ); Thu, 19 Feb 2009 11:41:58 -0500 Received: from ozzy.localnet (dhpc-2-02.sissa.it [147.122.2.182]) by smtp.sissa.it (Postfix) with ESMTP id 992161B480A1 for ; Thu, 19 Feb 2009 17:41:55 +0100 (CET) From: Nicola Soranzo To: Linux Media Subject: [PATCH] em28xx: register device to soundcard for sysfs Date: Thu, 19 Feb 2009 17:41:56 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902191741.57767.nsoranzo@tiscali.it> Sender: linux-media-owner@vger.kernel.org List-ID: As explained in "Writing an ALSA driver" (T. Iwai), audio drivers should set the struct device for the card before registering the card instance. This will add the correct /sys/class/sound/cardN/device symlink, so HAL can see the device and ConsoleKit sets its ACL permissions for the logged-in user. For em28xx audio capture cards found e.g. in Hauppauge WinTV-HVR-900 (R2), this patch fixes errors like: ALSA lib pcm_hw.c:1429:(_snd_pcm_hw_open) Invalid value for card Error opening audio: Permission denied when running mplayer as a normal user. Priority: normal Signed-off-by: Nicola Soranzo --- diff -r 80e785538796 -r ef8cc17cc048 linux/drivers/media/video/em28xx/em28xx-audio.c --- a/linux/drivers/media/video/em28xx/em28xx-audio.c Wed Feb 18 18:27:33 2009 +0100 +++ b/linux/drivers/media/video/em28xx/em28xx-audio.c Thu Feb 19 17:36:44 2009 +0100 @@ -560,6 +560,8 @@ pcm->info_flags = 0; pcm->private_data = dev; strcpy(pcm->name, "Empia 28xx Capture"); + + snd_card_set_dev(card, &dev->udev->dev); strcpy(card->driver, "Empia Em28xx Audio"); strcpy(card->shortname, "Em28xx Audio"); strcpy(card->longname, "Empia Em28xx Audio");