From: John Levon Subject: Re: [PATCH] pygrub: parse xen module option in grub Date: Thu, 19 Feb 2009 21:55:05 -0500 Message-ID: <20090220025505.GA5452@movementarian.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Wei Kong Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Fri, Feb 20, 2009 at 10:40:14AM +0800, Wei Kong wrote: > Add function for GrubConf to parse xen module option in grub. Why? > Pygrub should pass args as domUloader did. domUloader was never in the tree. > - sxp += "(args \"%s\")" % chosencfg["args"] > + sxp += "(args \"%s %s\")" % (chosencfg["args"], incfg["args"]) Are you trying to let the user add arguments to the ones specified in grub? Why? The patch is wrong anyway, you can't just add on the incoming args for Solaris at least. At the very least you need to add the args only when run_grub() is called. john