From: John Levon Subject: Re: [PATCH] pygrub: parse xen module option in grub Date: Thu, 19 Feb 2009 22:24:35 -0500 Message-ID: <20090220032435.GB7709@movementarian.org> References: <20090220025505.GA5452@movementarian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Wei Kong Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Fri, Feb 20, 2009 at 11:20:38AM +0800, Wei Kong wrote: > > The patch is wrong anyway, you can't just add on the incoming args for > > Solaris at least. At the very least you need to add the args only when > > run_grub() is called. > > > No, I didn't add any args for solaris. > Because I don't want to add args for Solaris, so I add args here, not in > run_grub(). Please read the code more closely: again, you cannot just pass inargs out again, you must only do so if run_grub() is called. Presuming it even makes sense - why can't the user edit the grub entry? john