From: John Levon Subject: Re: [PATCH] pygrub: parse xen module option in grub Date: Thu, 19 Feb 2009 23:21:51 -0500 Message-ID: <20090220042151.GC7709@movementarian.org> References: <20090220025505.GA5452@movementarian.org> <20090220032435.GB7709@movementarian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Wei Kong Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Fri, Feb 20, 2009 at 12:15:30PM +0800, Wei Kong wrote: > Do you like the below modify? It's probably nicer to show the incoming arguments in the grub emulation certainly, although I'm still unclear as to why you'd want this. Your patch does fix the Solaris case, so I'm not too fussed either way. regards, john