From: Wolfgang Denk Date: Sat, 21 Feb 2009 22:16:58 +0100 Subject: [U-Boot] [PATCH] mflash u-boot support In-Reply-To: <57afda040902020032h760174adja5ecba853ef6863b@mail.gmail.com> References: <57afda040901052341g3b00f741r445c0ce8d33b7b71@mail.gmail.com> <20090127223300.C93CB832E416@gemini.denx.de> <57afda040902020032h760174adja5ecba853ef6863b@mail.gmail.com> Message-ID: <20090221211658.EE86F832E43F@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear unsik Kim, In message <57afda040902020032h760174adja5ecba853ef6863b@mail.gmail.com> you wrote: > Hello? > > I fixed and added followings for your requests. > > 1. too long line length => fixed > > 2. not a linux coding style => fixed > > 3. add document (doc/README.mflash) > > 4. ARM only dependency and always init problem => fixed > > 5. msecs_to_hz function is changed. > In some ARM platform, CONFIG_SYS_HZ is not 1000 (samsung s3c24xx, > intel pxa25x, pxa27x) > and get_timer() just return elapsed tick of OS timer. > For the compatibility of these, I use #ifdef. > > Any comments, advice will be appreciated. > > Here is fixed patch. > > unsik Kim > > Signed-off-by: unsik Kim > --- > common/Makefile | 2 + > common/cmd_mgdisk.c | 76 ++++++ > common/cmd_nvedit.c | 8 +- > common/env_mgdisk.c | 90 ++++++ > disk/part.c | 8 +- > disk/part_amiga.c | 5 +- > disk/part_dos.c | 1 + > disk/part_efi.c | 1 + > disk/part_iso.c | 1 + > disk/part_mac.c | 1 + > doc/README.mflash | 93 +++++++ > drivers/block/Makefile | 5 +- > drivers/block/mg_disk.c | 629 +++++++++++++++++++++++++++++++++++++++++++ > drivers/block/mg_disk_prv.h | 140 ++++++++++ > fs/fat/fat.c | 2 + > include/config_cmd_all.h | 1 + > include/environment.h | 12 + > include/mg_disk.h | 51 ++++ > include/part.h | 1 + > 19 files changed, 1119 insertions(+), 8 deletions(-) Sorry, in the mean time this commit has been checked in: commit 2fb2604d5c20beb061b0a94282b7f6eb14d00cb8 Author: Peter Tyser Date: Tue Jan 27 18:03:12 2009 -0600 Command usage cleanup Can you please rebase and resubmit your patch? Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de What is research but a blind date with knowledge? -- Will Harvey