From: Wolfgang Denk Date: Mon, 23 Feb 2009 00:19:08 +0100 Subject: [U-Boot] [PATCH] Davinci I2C code cleanup In-Reply-To: References: <20090222124436.GA9867@game.jcrosoft.org> <20090222212738.E6971832E43F@gemini.denx.de> <20090222220629.666E4832E43F@gemini.denx.de> Message-ID: <20090222231908.94173832E43F@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear ksi at koi8.net, In message you wrote: > > > I am sure you could come up with an efficient *and* clean solution - if > > you really wanted to try. > > There is no way you can avoid that very same code repeated several times (7 > or so? didn't count them) -- that is how the driver works. See above - I wrote "if you really wanted to try." You don't. > > The code as is is not acceptable and needs to be cleaned up. > > Why not? What is wrong with that code? I will not explain it again. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A person who is more than casually interested in computers should be well schooled in machine language, since it is a fundamental part of a computer. -- Donald Knuth