From: Wolfgang Denk Date: Wed, 25 Feb 2009 09:57:04 +0100 Subject: [U-Boot] [PATCH 01/11] mkconfig: export ARCH, CPU, SOC, BOARD, VENDOR to config.h In-Reply-To: <20090225082333.GD26416@game.jcrosoft.org> References: <20090225060934.GB26416@game.jcrosoft.org> <1235542278-21451-1-git-send-email-plagnioj@jcrosoft.com> <20090225073832.E462D832E88B@gemini.denx.de> <20090225082333.GD26416@game.jcrosoft.org> Message-ID: <20090225085704.88CFF832E43F@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jean-Christophe PLAGNIOL-VILLARD, In message <20090225082333.GD26416@game.jcrosoft.org> you wrote: > > > > -[ "$5" ] && [ "$5" != "NULL" ] && echo "VENDOR = $5" >> config.mk > > > +[ "$5" ] && [ "$5" != "NULL" ] && { > > > + echo "VENDOR = $5" >> config.mk > > > + echo "#define CONFIG_VENDOR $5" >> config.h > > > +} > > > > Please do NOT do this. > > > > The setting up CONFIG_ options is done in the board config file, and > > NOT in the Makefile. > > > > This patch will cause conflicts with MANY boards. > > > > > > Maybe you would like to explain WHY you are trying to do that? > whe need to known which CPU, BOARD and co is currently use to the generate the > lds > as example to specify the start.o to use But you do not generate the linker script from the C header file - that makes no sense to me. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Build a system that even a fool can use and only a fool will want to use it.