From: Mike Frysinger Date: Wed, 25 Feb 2009 12:01:44 -0500 Subject: [U-Boot] [PATCH] netloop: updates for NetLoop In-Reply-To: <49A53C4D.5060907@denx.de> References: <49A53C4D.5060907@denx.de> Message-ID: <200902251201.45611.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 25 February 2009 07:40:45 Heiko Schocher wrote: > +/* > + * This variable is incremented on each do_setenv (), so it can > + * be used as an indication, if the environment has changed or not. > + * So it is possible to reread an environment variable only if the > + * environment was changed ... done so for example in NetInitLoop() > + */ i would tweak it to say "... it can be used via get_env_id() as an ..." > - return 0; > + return; > } a return at the end of a function is pointless imo. just delete it. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090225/0c8747d6/attachment.pgp