From: David Miller Subject: Re: [PATCH 2/2] veth: Configurable nterface MTU Date: Fri, 27 Feb 2009 02:49:16 -0800 (PST) Message-ID: <20090227.024916.184944062.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: netdev-owner@vger.kernel.org To: ebiederm@xmission.com Cc: netdev@vger.kernel.org, containers@lists.osdl.org List-Id: containers.vger.kernel.org From: ebiederm@xmission.com (Eric W. Biederman) Date: Wed, 25 Feb 2009 21:49:04 -0800 > @@ -249,6 +253,19 @@ static int veth_close(struct net_device *dev) > return 0; > } > > +static int is_valid_veth_mtu(int new_mtu) > +{ > + return (new_mtu >= MIN_MTU && new_mtu <= MAX_MTU); > +} > + > +static int veth_change_mtu(struct net_device *dev, int new_mtu) > +{ > + if (is_valid_veth_mtu(new_mtu)) > + return -EINVAL; > + dev->mtu = new_mtu; > + return 0; > +} > + This validity test seems to be reversed?