From: Simon Kagstrom Subject: Re: [PATCH 2/2] spi_bitbang: Add support for non-blocking synchronous transfers Date: Sat, 28 Feb 2009 11:15:24 +0100 Message-ID: <20090228111524.1594a58e@lska2> References: <20090228081036.31964.80618.stgit@fedora.yogi> <20090228081117.31964.51155.stgit@fedora.yogi> <20090228100914.2ec2ff7f@lska2> <20090228095846.GA32044@fedora.yogi> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Andy Green , David Brownell , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Balaji Rao Return-path: In-Reply-To: <20090228095846.GA32044-bnrf61MYqdMYW0ZX77RX+A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Sat, 28 Feb 2009 15:28:48 +0530 Balaji Rao wrote: > The master is not spi_s3c24xx but spi_s3x24xx_gpio, whose txrx are > very simple code. > > Additionally all of this has been tested and found to work. The code, > along with the modified new spi based lis302dl driver is all in > andy-tracking [1]. Oh, I didn't notice that. Nice then. I see from the git logs that this and some other related patches have been added now. Another question I have then is about the name: to me spi_non_blocking_transfer() sounds like it would do the opposite of what I guess it does - it would go ahead without blocking on the call. I guess what the name means is that it will not sleep during the call, but for pushing it upstream, could it be better to name it something else? Perhaps spi_sync and then rename the existing API name (which I think is more than a bit strange), or maybe spi_sync_nowait or something? // Simon ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H