Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LeNsR-00025Y-I8 for qemu-devel@nongnu.org; Tue, 03 Mar 2009 01:13:15 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LeNsQ-00025E-RM for qemu-devel@nongnu.org; Tue, 03 Mar 2009 01:13:15 -0500 Received: from [199.232.76.173] (port=39203 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LeNsQ-000259-9w for qemu-devel@nongnu.org; Tue, 03 Mar 2009 01:13:14 -0500 Received: from hall.aurel32.net ([88.191.82.174]:38373) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LeNsP-000579-Sv for qemu-devel@nongnu.org; Tue, 03 Mar 2009 01:13:14 -0500 Date: Tue, 3 Mar 2009 07:13:07 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] SH4: Fixed last UTLB unused Message-ID: <20090303061307.GB5159@volta.aurel32.net> References: <1234824063.8648.6.camel@cocoduo.atr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1234824063.8648.6.camel@cocoduo.atr> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lionel Landwerlin Cc: qemu-devel@nongnu.org On Mon, Feb 16, 2009 at 11:41:03PM +0100, Lionel Landwerlin wrote: > With my previous patch (the one monitoring tlb), I found that the last > TLB entry was never use. Here a little fix. > > > Signed-off-by: Lionel Landwerlin Thanks, applied. > --- > target-sh4/helper.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-sh4/helper.c b/target-sh4/helper.c > index cd0f392..918a946 100644 > --- a/target-sh4/helper.c > +++ b/target-sh4/helper.c > @@ -305,7 +305,7 @@ static void increment_urc(CPUState * env) > urb = ((env->mmucr) >> 18) & 0x3f; > urc = ((env->mmucr) >> 10) & 0x3f; > urc++; > - if (urc == urb || urc == UTLB_SIZE - 1) > + if (urc == urb || urc == UTLB_SIZE) > urc = 0; > env->mmucr = (env->mmucr & 0xffff03ff) | (urc << 10); > } > -- > 1.5.6.5 > > > -- > Lione Landwerlin >  > O p e n W i d e 14, rue Gaillon 75002 Paris > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net