Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LepOg-0001vy-TO for mharc-grub-devel@gnu.org; Wed, 04 Mar 2009 06:36:22 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LepOe-0001sC-Fy for grub-devel@gnu.org; Wed, 04 Mar 2009 06:36:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LepOe-0001rv-22 for grub-devel@gnu.org; Wed, 04 Mar 2009 06:36:20 -0500 Received: from [199.232.76.173] (port=55032 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LepOd-0001rs-So for grub-devel@gnu.org; Wed, 04 Mar 2009 06:36:19 -0500 Received: from [74.93.104.97] (port=34720 helo=sunset.davemloft.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LepOd-0002kk-GJ for grub-devel@gnu.org; Wed, 04 Mar 2009 06:36:19 -0500 Received: from localhost (localhost [127.0.0.1]) by sunset.davemloft.net (Postfix) with ESMTP id 6544635C04E; Wed, 4 Mar 2009 03:36:05 -0800 (PST) Date: Wed, 04 Mar 2009 03:36:05 -0800 (PST) Message-Id: <20090304.033605.238092958.davem@davemloft.net> To: grub-devel@gnu.org, chaac@nic.fi From: David Miller In-Reply-To: <49AE6756.10404@nic.fi> References: <20090303.181513.19285049.davem@davemloft.net> <49AE6756.10404@nic.fi> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Subject: Re: [PATCH 1/7]: Fix sparc64 setjmp implementation. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2009 11:36:21 -0000 From: Vesa J=E4=E4skel=E4inen Date: Wed, 04 Mar 2009 13:34:46 +0200 > David Miller wrote: > > diff --git a/include/grub/sparc64/setjmp.h b/include/grub/sparc64/s= etjmp.h > > index 12d8e01..183a820 100644 > > --- a/include/grub/sparc64/setjmp.h > > +++ b/include/grub/sparc64/setjmp.h > > @@ -19,8 +19,7 @@ > > #ifndef GRUB_SETJMP_CPU_HEADER > > #define GRUB_SETJMP_CPU_HEADER 1 > > = > > -/* FIXME (sparc64). */ > > -typedef unsigned long grub_jmp_buf[20]; > > +typedef unsigned long grub_jmp_buf[3]; > = > I assume unsigned long is 64bit in sparc? Yes, for sparc64 long is always 64-bit, no exceptions. > Would it be more practical to use grub_uint64_t? This is a "sparc64" file, so I don't think so. > Are there any other registers that needs to be preserved ? Not for GRUB, no.