From: Jeremy Allison Subject: Re: [CIFS] [PATCH] warn on EINVAL error on posix open, and turn off posix open if server broken for this call Date: Wed, 4 Mar 2009 11:29:07 -0800 Message-ID: <20090304192907.GB9885@samba1> References: <524f69650903041102v415a807m8a93f0462458a51@mail.gmail.com> <1236194670.22692.0.camel@pico.li.ssimo.org> Reply-To: Jeremy Allison Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Steve French , Jeff Layton , linux-fsdevel , "linux-cifs-client@lists.samba.org" , samba-technical To: simo Return-path: Content-Disposition: inline In-Reply-To: <1236194670.22692.0.camel@pico.li.ssimo.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cifs-client-bounces+glfc-linux-cifs-client=gmane.org@lists.samba.org Errors-To: linux-cifs-client-bounces+glfc-linux-cifs-client=gmane.org@lists.samba.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Mar 04, 2009 at 02:24:30PM -0500, simo wrote: > On Wed, 2009-03-04 at 13:02 -0600, Steve French wrote: > > Attached is patch to workaround the problem found in posix open to > > Samba versions 3.3.1 and earlier > > (create works, but open would fail with invalid parameter) - it > > disables requests to try posix open after > > a first failure. > > Why do you completely disable posix opens ? > Wouldn't it make sense to reopen only when it fails ? > After all when you create new files it works correctly. No, you don't want to do this complexity. Much more simple to just disable that call if you're running against a buggy server. Jeremy.