Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LeySD-0007uV-MU for mharc-grub-devel@gnu.org; Wed, 04 Mar 2009 16:16:37 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LeySB-0007sW-9x for grub-devel@gnu.org; Wed, 04 Mar 2009 16:16:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LeyS9-0007qj-DQ for grub-devel@gnu.org; Wed, 04 Mar 2009 16:16:34 -0500 Received: from [199.232.76.173] (port=58387 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LeyS9-0007qX-8O for grub-devel@gnu.org; Wed, 04 Mar 2009 16:16:33 -0500 Received: from aybabtu.com ([69.60.117.155]:33778) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LeyS8-0007QH-SA for grub-devel@gnu.org; Wed, 04 Mar 2009 16:16:33 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LeyKX-0002BP-90 for grub-devel@gnu.org; Wed, 04 Mar 2009 22:08:41 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LeyS5-0008Bc-FK for grub-devel@gnu.org; Wed, 04 Mar 2009 22:16:29 +0100 Date: Wed, 4 Mar 2009 22:16:29 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090304211629.GJ31201@thorin> References: <20090304163509.GA26106@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090304163509.GA26106@riva.ucam.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Support up to 256 SCSI disks on Linux X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2009 21:16:35 -0000 On Wed, Mar 04, 2009 at 04:35:09PM +0000, Colin Watson wrote: > Linux's Documentation/devices.txt file says that up to 256 SCSI disks > are supported. GRUB currently only supports the first 16. Wikimedia > filed an Ubuntu bug report about this > (https://bugs.launchpad.net/bugs/335174), so here's a patch to extend > this. (I really haven't been able to test this much at all beyond > compile-testing as I don't have a suitable system myself ...) > > I suppose it might be nice to macroify the stuff in > grub_util_getdiskname, but TBH I'm not sure it would shorten it all that > much or make it much more readable, so I didn't bother. Hi Colin, I feel some dejavu. I think this is not the first max disk limit you find ;-) > else if (major == SCSI_DISK0_MAJOR) > - sprintf (name, "/dev/sd%c", 'a' + minor / 16); > + grub_util_getdiskname_scsi (name, 0, minor / 16); > + else if (major == SCSI_DISK1_MAJOR) > + grub_util_getdiskname_scsi (name, 1, minor / 16); > [...] Can this be factorized somehow? Space in raid.mod is quite critical; when used it usually ends up in core.img, which needs to fit in the embed area. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."