Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LfkaL-0005Ld-7a for mharc-grub-devel@gnu.org; Fri, 06 Mar 2009 19:40:13 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LfkaJ-0005KD-7d for grub-devel@gnu.org; Fri, 06 Mar 2009 19:40:11 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LfkaI-0005JH-8F for grub-devel@gnu.org; Fri, 06 Mar 2009 19:40:10 -0500 Received: from [199.232.76.173] (port=55829 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfkaH-0005J5-Sc for grub-devel@gnu.org; Fri, 06 Mar 2009 19:40:09 -0500 Received: from [74.93.104.97] (port=39905 helo=sunset.davemloft.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LfkaF-0002x8-H3; Fri, 06 Mar 2009 19:40:07 -0500 Received: from localhost (localhost [127.0.0.1]) by sunset.davemloft.net (Postfix) with ESMTP id D98DBC8D940; Fri, 6 Mar 2009 16:39:53 -0800 (PST) Date: Fri, 06 Mar 2009 16:39:53 -0800 (PST) Message-Id: <20090306.163953.27529500.davem@davemloft.net> To: grub-devel@gnu.org, proski@gnu.org From: David Miller In-Reply-To: <1236366237.7680.2.camel@mj> References: <200903050804.07474.ml@isaac.cedarswampstudios.org> <20090306185553.GA28703@thorin> <1236366237.7680.2.camel@mj> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Subject: Re: [PATCH 1/7]: Fix sparc64 setjmp implementation. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Mar 2009 00:40:11 -0000 From: Pavel Roskin Date: Fri, 06 Mar 2009 14:03:57 -0500 > On Fri, 2009-03-06 at 19:55 +0100, Robert Millan wrote: > > On Thu, Mar 05, 2009 at 08:04:07AM -0500, Isaac Dupree wrote: > > > > We've been using "unsigned long" for storing virtual addresses in the > > > > Linux kernel for 10+ years and it works just fine. :-) > > > > > > and Linux kernel uses GCC compiler in precise ways > > > > > > I believe that ptrdiff_t is the proper standardized type for an integer the > > > size of a pointer. except... it's always signed :-) > > > > > > Can you just use pointer types and pointer arithmetic? > > > > > > also, standards aside, a common way to get such a type, is "configure" script > > > testing various possibilities like "unsigned long" and "unsigned long long" > > > and seeing which one is the right size for the target architecture. (not sure > > > if that works when cross-compiling though) > > > > I think we're already using longs this way in quite a few places. It's not > > such a big deal IMHO. > > I was considering making grub_size_t long and grub_ssize_t unsigned > long. I remember that it required many changes in string formats, so I > didn't feel it would be justified. But we could try it again. You should use whatever is the appropriate size_t/ssize_t type on the given platform+ABI, and that way GRUB could use "%Zd" and/or "%zd" throughout. Was that the plan?