Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LgNzW-00088C-Vu for qemu-devel@nongnu.org; Sun, 08 Mar 2009 14:44:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LgNzV-00087P-E7 for qemu-devel@nongnu.org; Sun, 08 Mar 2009 14:44:50 -0400 Received: from [199.232.76.173] (port=40855 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LgNzV-00087D-2Q for qemu-devel@nongnu.org; Sun, 08 Mar 2009 14:44:49 -0400 Received: from hall.aurel32.net ([88.191.82.174]:57943) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LgNzU-0008Sx-J1 for qemu-devel@nongnu.org; Sun, 08 Mar 2009 14:44:48 -0400 Date: Sun, 8 Mar 2009 19:44:44 +0100 From: Aurelien Jarno Message-ID: <20090308184444.GT32521@hall.aurel32.net> References: <20090221190054.12485.30486.stgit@mchn012c.ww002.siemens.net> <20090221190055.12485.61603.stgit@mchn012c.ww002.siemens.net> <49B3DC8C.6050700@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <49B3DC8C.6050700@web.de> Sender: Aurelien Jarno Subject: [Qemu-devel] Re: [PATCH 1/7] clean build: Add bt_host_hci prototype Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel On Sun, Mar 08, 2009 at 03:56:12PM +0100, Jan Kiszka wrote: > Jan Kiszka wrote: > > Silence compiler warning by providing a prototype in the CONFIG_BLUEZ > > case (hw/bt.h provides it otherwise). > > > > Signed-off-by: Jan Kiszka > > --- > > > > bt-host.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/bt-host.c b/bt-host.c > > index 07679f6..066757a 100644 > > --- a/bt-host.c > > +++ b/bt-host.c > > @@ -31,6 +31,8 @@ > > # include > > # include > > # include > > +/* Silence compiler warning */ > > +struct HCIInfo *bt_host_hci(const char *id); > > # else > > # include "hw/bt.h" > > # define HCI_MAX_FRAME_SIZE 1028 > > Thanks for applying the other patches, but this tiny one always seems to > be ignored - for unknown reasons. :) > On my side, I consider that a hack, not a fix. We should make sure the correct header is included so that this function is declared. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net