From: Brendan Cully Subject: Re: Design document of Kemari Date: Tue, 10 Mar 2009 09:51:33 -0700 Message-ID: <20090310165133.GA6336@zanzibar.lan> References: <49B63E06.2030402@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel , Yoshisato YANAGISAWA , Yoshiaki Tamura List-Id: xen-devel@lists.xenproject.org On Tuesday, 10 March 2009 at 10:38, Keir Fraser wrote: > On 10/03/2009 10:16, "Yoshisato YANAGISAWA" > wrote: > > >> Yes, we prefer a merged save/restore codebase. > > > > Since Kemari requires transaction-like feature, xc_dom_kemari_save > > should wait acknowledgment from xc_dom_kemari_restore. > > Xc_dom_kemari_restore should also buffer data until complete snapshot > > received from xc_dom_kemari_save. > > Because of this reason, there might be large if-else statements if those > > code are merged. > > > > Isn't it make xc_domain_save and xc_domain_restore too complexed? > > Well, you can leave it for now pending further investigation. I also want to > see what the Remus approach is for this. The main change to xc_domain_save is to split out the code that does a round into its own function so that it can be called externally. I'll have the patches together soon.