Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LiCmT-00073X-9c for mharc-grub-devel@gnu.org; Fri, 13 Mar 2009 15:10:53 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LiCmR-00070n-EU for grub-devel@gnu.org; Fri, 13 Mar 2009 15:10:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LiCmM-0006wt-G6 for grub-devel@gnu.org; Fri, 13 Mar 2009 15:10:50 -0400 Received: from [199.232.76.173] (port=59038 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LiCmM-0006wq-9x for grub-devel@gnu.org; Fri, 13 Mar 2009 15:10:46 -0400 Received: from aybabtu.com ([69.60.117.155]:56923) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LiCmL-0003zz-T5 for grub-devel@gnu.org; Fri, 13 Mar 2009 15:10:46 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LiCdl-0008Gc-VI for grub-devel@gnu.org; Fri, 13 Mar 2009 20:01:56 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LiCm6-0004TU-KA for grub-devel@gnu.org; Fri, 13 Mar 2009 20:10:30 +0100 Date: Fri, 13 Mar 2009 20:10:30 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090313191030.GB17068@thorin> References: <49AAB6E6.2080805@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49AAB6E6.2080805@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] FAT, UFS and mtime X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2009 19:10:51 -0000 On Sun, Mar 01, 2009 at 05:25:10PM +0100, phcoder wrote: > Hello all. It seems that gcc has trouble with -m32 when structure is > passed as argument. So I replaced that part by a pointer. Also I made > some improvements to ufs code to support solaris branch of ufs. I tested > it also with freebsd and netbsd's branch and it works fine on it too. > As my 3 FS patches: mtime, FAT and UFS are interdependent I submit a > patch with all 3 features. If it's really necessary I can split them but > it requires a lot of unnecessary work Please do. It is definitely confusing to review patches that merge unrelated things. Also, please don't include the changelog entry in your patch, since those break too easily. Just paste it at the top of your mail. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."