Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LisPM-0006VF-Do for mharc-grub-devel@gnu.org; Sun, 15 Mar 2009 11:37:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LisPK-0006Tw-Nt for grub-devel@gnu.org; Sun, 15 Mar 2009 11:37:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LisPF-0006T1-J1 for grub-devel@gnu.org; Sun, 15 Mar 2009 11:37:45 -0400 Received: from [199.232.76.173] (port=48282 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LisPF-0006Sm-8l for grub-devel@gnu.org; Sun, 15 Mar 2009 11:37:41 -0400 Received: from aybabtu.com ([69.60.117.155]:56004) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LisPE-0000Dm-Kx for grub-devel@gnu.org; Sun, 15 Mar 2009 11:37:40 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LisGa-00041K-CR for grub-devel@gnu.org; Sun, 15 Mar 2009 16:28:45 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LisPB-0006PX-8i for grub-devel@gnu.org; Sun, 15 Mar 2009 16:37:37 +0100 Date: Sun, 15 Mar 2009 16:37:37 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090315153737.GB24554@thorin> References: <200903150627.34301.okuji@enbug.org> <1237113198.3490.0.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1237113198.3490.0.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Bug fix for ext2.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Mar 2009 15:37:46 -0000 On Sun, Mar 15, 2009 at 11:33:18AM +0100, Felix Zielcke wrote: > Am Sonntag, den 15.03.2009, 14:00 +0800 schrieb Bean: > > > Hi, > > Hi Bean, > > > Oh right, this one should be ok. > > + grub_error (GRUB_ERR_BAD_FS, "not an xfs filesystem"); > This should probable be `not an ext2 filesystem' :) Why override grub_errmsg anyway? "not ext2" isn't going to be more useful than a "read out of range" text when displayed to the user. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."